Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unwanted curl #117

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@PierreRambaud
Copy link
Contributor

commented Jul 25, 2019

Remove unwanted curl which is sometimes failing

Tests:
Make sure you can install / upgrade the module :)


This change is Reviewable

@PierreRambaud PierreRambaud added this to the 3.2.0 milestone Jul 25, 2019

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

Looks good, but why was the curl added in the 1st place ? I'm asking to be sure we dont disable some feature (because I dont see any replacement)

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

This is since the first commit of this module, without comment or reason.
Since it can cause trouble for someone, and because the file_get_contents do exactly the same as the called function (indexPrices) we have no reason to keep this one.

@sarahdib sarahdib added QA approved and removed Waiting for QA labels Jul 30, 2019

@PierreRambaud PierreRambaud merged commit 48f7a81 into PrestaShop:dev Jul 30, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:remove-curl branch Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.