Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Products are displayed in wrong order when sorted by "position" and "Show products from subcategories" is disabled #125

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@PierreRambaud
Copy link
Contributor

commented Aug 19, 2019

Fixes PrestaShop/PrestaShop#15062


This change is Reviewable

@matks
matks approved these changes Aug 20, 2019
@sarahdib sarahdib self-assigned this Aug 29, 2019
@sarahdib sarahdib added QA approved and removed Waiting for QA labels Aug 29, 2019
@PierreRambaud PierreRambaud merged commit 42b5708 into PrestaShop:dev Aug 29, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/categories-sorting branch Aug 29, 2019
@shaffe-fr

This comment has been minimized.

Copy link

commented on src/Product/Search.php in 4162df5 Oct 2, 2019

@PierreRambaud This causes an error when the current query uses a 'category' search filter. I didn't find a fix yet, but we might need to rework \PrestaShop\Module\FacetedSearch\Adapter\MySQL::computeWhereConditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.