Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong nested array in maxvalue #126

Merged
merged 5 commits into from Aug 29, 2019

Conversation

@matrixino
Copy link
Contributor

commented Aug 23, 2019

This fixes a problem wth maxprice var.
Previously, when $minPrice was > $maxPrice[$idCountry][$currency['id_currency']], it would add the whole minprice array to maxprice instead of the single value.
This leads to a wrong nested array and make products impossible to save in the BO (error 500 for unsupported operand types at line 548).
We only need to assign the single value.


This change is Reviewable

PierreRambaud and others added 3 commits Jul 5, 2019
Release 3.1.0
Release 3.2.0
ps_facetedsearch.php Outdated Show resolved Hide resolved
ps_facetedsearch.php Outdated Show resolved Hide resolved
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

Any news? We planned to release a new version today and we want to integrate the fix.

@matrixino

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

Any news? We planned to release a new version today and we want to integrate the fix.

Yes, changing it with $price is even better. Mine was a quick fix.
532: $maxPrice[$idCountry][$currency['id_currency']] = $price;

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

Could you update your pull request or should I create a new one? (I'm not able to update your branch)

@matrixino

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

Could you update your pull request or should I create a new one? (I'm not able to update your branch)

Is it ok now?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

Not yet. One more thing needs to be update. :)

@matrixino

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

Not yet. One more thing needs to be update. :)

By me? Which one? I updated the diff already.

@matrixino

This comment has been minimized.

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

Thanks, wait for CI and merge :)

@PierreRambaud PierreRambaud changed the base branch from master to dev Aug 29, 2019
@PierreRambaud PierreRambaud merged commit 0812f75 into PrestaShop:dev Aug 29, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.