Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong filter price, need match shop current #136

Merged
merged 1 commit into from Sep 13, 2019

Conversation

@alex4102
Copy link
Contributor

commented Sep 13, 2019

This change is Reviewable

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2019

Hi and thanks for your contribution.
Can you update unit tests?

Copy link
Contributor

left a comment

Tests are failing

@alex4102

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2019

I updated tests but I dont know, why I have this error : "Mockery\Exception\BadMethodCallException: Method Mockery_2_Db::executeS() does not exist on this mock object"

@PierreRambaud PierreRambaud force-pushed the alex4102:patch-1 branch from bcbf087 to cc9c634 Sep 13, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2019

I fixed your tests and squash your commit ;)

@alex4102

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2019

I fixed your tests and squash your commit ;)

Thanks

@PierreRambaud PierreRambaud force-pushed the alex4102:patch-1 branch from cc9c634 to 7deb050 Sep 13, 2019
@sarahdib sarahdib added QA approved and removed Waiting for QA labels Sep 13, 2019
@PierreRambaud PierreRambaud merged commit bc939c7 into PrestaShop:dev Sep 13, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2019

Thanks @alex4102

@PierreRambaud PierreRambaud added this to the 3.3.0 milestone Sep 13, 2019
@PierreRambaud PierreRambaud added the bug label Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.