Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url validation #145

Merged
merged 2 commits into from Oct 15, 2019

Conversation

@rokaszygmantas
Copy link
Contributor

rokaszygmantas commented Oct 3, 2019

This module adds 2 new fields in PrestaShop's feature edit form. The validation of the URL field was incorrectly implemented in this PR: #133

With this PR it should validate URL value the same way as it was validating prior to #133 PR

https://prnt.sc/pebc50


This change is Reviewable

@rokaszygmantas

This comment has been minimized.

Copy link
Contributor Author

rokaszygmantas commented Oct 3, 2019

@PierreRambaud @matks this PR fixes the validation issue introduced by #133 🙂

@rokaszygmantas

This comment has been minimized.

Copy link
Contributor Author

rokaszygmantas commented Oct 3, 2019

the build is failing on older PS versions, which are not supported by this version of ps_facetedsearch 🤔

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 4, 2019

@rokaszygmantas you can add the ignore line in phpstan.neon :)

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 7, 2019

I'll update phpstan tests in a separated PR to split phpstan config depending on the PrestaShop version.

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 8, 2019

Hey @rokaszygmantas I split phpstan configuration, you're now able to add what's missing depending on the PrestaShop version :) (A rebase is needed)

@PierreRambaud PierreRambaud force-pushed the rokaszygmantas:bugfix/url_validation branch from 9a25a93 to fd7be39 Oct 15, 2019
@PierreRambaud PierreRambaud added this to the 3.4.0 milestone Oct 15, 2019
@PierreRambaud PierreRambaud merged commit 84839d1 into PrestaShop:dev Oct 15, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@rokaszygmantas

This comment has been minimized.

Copy link
Contributor Author

rokaszygmantas commented Oct 15, 2019

thank you @PierreRambaud, I couldn't find time to do these last fixes that you did 🙂

@rokaszygmantas rokaszygmantas deleted the rokaszygmantas:bugfix/url_validation branch Oct 15, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 15, 2019

@rokaszygmantas No problem, @matks already told me you're busy 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.