Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use specific prestashop version for phpstan #146

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@PierreRambaud
Copy link
Contributor

PierreRambaud commented Oct 8, 2019

Just split phpstan configuration.

No need QA.

This change is Reviewable

@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/phpstan branch 5 times, most recently from cbe1dd5 to 199b076 Oct 8, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 8, 2019

The command "docker exec -ti temp-ps rm -rf /var/www/html/modules/ps_facetedsearch" exited with 0.
4.10s$ docker run --rm --volumes-from temp-ps -v $PWD:/var/www/html/modules/ps_facetedsearch -e _PS_ROOT_DIR_=/var/www/html quetzacoalt/phpstan analyse --configuration=/var/www/html/modules/ps_facetedsearch/tests/php/phpstan/phpstan-1.7.5.2.neon
Unable to find image 'quetzacoalt/phpstan:latest' locally
latest: Pulling from quetzacoalt/phpstan
Status: Downloaded newer image for quetzacoalt/phpstan:latest
Project config file at path /var/www/html/modules/ps_facetedsearch/tests/php/phpstan/phpstan-1.7.5.2.neon does not exist.
The command "docker run --rm --volumes-from temp-ps -v $PWD:/var/www/html/modules/ps_facetedsearch -e _PS_ROOT_DIR_=/var/www/html quetzacoalt/phpstan analyse --configuration=/var/www/html/modules/ps_facetedsearch/tests/php/phpstan/phpstan-1.7.5.2.neon" exited with 1.
@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/phpstan branch from 199b076 to 31dbc9e Oct 8, 2019
@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/phpstan branch from 31dbc9e to ff76226 Oct 8, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Oct 8, 2019

The command "docker exec -ti temp-ps rm -rf /var/www/html/modules/ps_facetedsearch" exited with 0.
4.10s$ docker run --rm --volumes-from temp-ps -v $PWD:/var/www/html/modules/ps_facetedsearch -e _PS_ROOT_DIR_=/var/www/html quetzacoalt/phpstan analyse --configuration=/var/www/html/modules/ps_facetedsearch/tests/php/phpstan/phpstan-1.7.5.2.neon
Unable to find image 'quetzacoalt/phpstan:latest' locally
latest: Pulling from quetzacoalt/phpstan
Status: Downloaded newer image for quetzacoalt/phpstan:latest
Project config file at path /var/www/html/modules/ps_facetedsearch/tests/php/phpstan/phpstan-1.7.5.2.neon does not exist.
The command "docker run --rm --volumes-from temp-ps -v $PWD:/var/www/html/modules/ps_facetedsearch -e _PS_ROOT_DIR_=/var/www/html quetzacoalt/phpstan analyse --configuration=/var/www/html/modules/ps_facetedsearch/tests/php/phpstan/phpstan-1.7.5.2.neon" exited with 1.

Still working on it :)

@matks
matks approved these changes Oct 8, 2019
@PierreRambaud PierreRambaud added this to the 3.4.0 milestone Oct 8, 2019
@PierreRambaud PierreRambaud merged commit 5fb05f3 into PrestaShop:dev Oct 8, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Oct 8, 2019

Thanks @matks for review

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/phpstan branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.