Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear cache button displays an error even on success #149

Merged
merged 1 commit into from Oct 16, 2019

Conversation

@PierreRambaud
Copy link
Contributor

PierreRambaud commented Oct 16, 2019

Something has changed on develop branch, this clear cache button displays an error message even if the cache is cleared


This change is Reviewable

@PierreRambaud PierreRambaud added this to the 3.4.0 milestone Oct 16, 2019
Copy link
Contributor

matthieu-rolland left a comment

LGTM, thank you !

@sarahdib sarahdib added QA approved and removed Waiting for QA labels Oct 16, 2019
@PierreRambaud PierreRambaud merged commit 6e5c5ab into PrestaShop:dev Oct 16, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@PierreRambaud PierreRambaud deleted the PierreRambaud:missing-return branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.