Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLDR number formatter for negative values #151

Merged
merged 2 commits into from Dec 11, 2019

Conversation

@jolelievre
Copy link
Contributor

jolelievre commented Dec 5, 2019

The component tried to detect if the number was negative on the wrong variable (absolute one so always positive)


This change is Reviewable

@jolelievre jolelievre requested a review from PierreRambaud Dec 5, 2019
@PierreRambaud PierreRambaud added this to the 3.5.0 milestone Dec 5, 2019
@PierreRambaud PierreRambaud merged commit 30eb649 into PrestaShop:dev Dec 11, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 11, 2019

No need QA, Thanks @jolelievre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.