Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show products that the user has access to #48

Open
wants to merge 1 commit into
base: dev
from

Conversation

@jonaseberle
Copy link

jonaseberle commented Dec 14, 2018

Before, ps_facetedsearach showed also products that the user did not have access to, e.g. because his user group was not in the product's categories.

This filters records to be only shown when the user has access to the detail page, too.


This change is Reviewable

Before, ps_facetedsearach showed also products that the user did not have access to, e.g. because his user group was not in the product's categories. 

This filters records to be only shown when the user has access to the detail page, too.
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Feb 21, 2019

Hi, and thanks for your contribution.
Unfortunately we are currently working on a huge refactoring of this module (#52), this is why we are not able to merge your pull request in the dev branch.
But, if you want you can improve the current pull request, of I can take your changes and had it in the PR.
Kind regards,

@jonaseberle

This comment has been minimized.

Copy link
Author

jonaseberle commented Feb 21, 2019

Hi @PierreRambaud, thank you for looking into it. I am sorry I cannot rebase and provide a further PR at the moment. Maybe we could keep this open until after or during the refactoring someone else wants to take care?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Feb 21, 2019

Yes of course! I'll include a reference to this PR when I'll fix this issue in the refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.