Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved some code from footer to head tag #116

Merged
merged 1 commit into from Apr 8, 2022

Conversation

Progi1984
Copy link
Contributor

Questions Answers
Description? Moved some code from footer to head tag
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#28004
How to test? Cf. PrestaShop/PrestaShop#28004

@Progi1984 Progi1984 added this to the 4.1.3 milestone Apr 4, 2022
@Progi1984 Progi1984 added the bug label Apr 4, 2022
@Progi1984 Progi1984 requested a review from a team April 4, 2022 14:58
@Progi1984 Progi1984 force-pushed the issue28004 branch 5 times, most recently from cdd4a0b to 95e8092 Compare April 4, 2022 19:09
@florine2623 florine2623 self-assigned this Apr 8, 2022
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Progi1984 ,

Thanks for the PR. Warning is not shown anymore.

Tested creation of order as guest and as customer, creation of order from BO. ps_ganalytics table is well updated with the info.
Tested multistore compatibility
Tested following actions : Disable, Disable mobile, Reset, Uninstall

It is QA ✅

@Progi1984 Progi1984 merged commit 227ac72 into PrestaShop:dev Apr 8, 2022
@Progi1984 Progi1984 deleted the issue28004 branch April 8, 2022 12:41
@Progi1984
Copy link
Contributor Author

Thanks @florine2623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants