New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only cast as array when a product is returned #14

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
3 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 28, 2018

Product content should be casted as an array only if we have an Product instance.

With the LazyArrays being introduced, casting these variables as arrays breaks the module execution. See details on PrestaShop/PrestaShop#10742

@marionf

This comment has been minimized.

marionf commented Oct 1, 2018

I can't change the label, but it's QA approved 👍

@eternoendless

This comment has been minimized.

Member

eternoendless commented Oct 1, 2018

Thank you @Quetzacoalt91

@eternoendless eternoendless merged commit dd7c119 into PrestaShop:dev Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment