Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dir constant #55

Merged
merged 2 commits into from Mar 15, 2019
Merged

Dir constant #55

merged 2 commits into from Mar 15, 2019

Conversation

@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 27, 2018

No description provided.

Quetzacoalt91 and others added 2 commits Sep 19, 2018
Deploying v3.0.1 of ps_legalcompliance
@rblaurin

This comment has been minimized.

Copy link

rblaurin commented Mar 14, 2019

I still don't know if we can use the DIR constant in modules. The module validator says it is forbidden. Why?

@Matt75

This comment has been minimized.

Copy link

Matt75 commented Mar 14, 2019

I still don't know if we can use the DIR constant in modules. The module validator says it is forbidden. Why?

Due to compatibility checker with PrestaShop 1.5/1.6 which require PHP 5.2
DIR constant has been introduced in PHP 5.3
I thinks it's allowed if you use PrestaShop 1.7 compliant option because it require PHP 5.4

@MathiasReker

This comment has been minimized.

Copy link
Contributor Author

MathiasReker commented Mar 14, 2019

You can use it for PS 1.7 But when possible you should rather use PrestaShop constants: https://blog.floriancourgey.com/2018/04/constants-and-variables-for-prestashop/

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Mar 15, 2019

So we can use this const because of https://github.com/PrestaShop/ps_legalcompliance/blob/master/ps_legalcompliance.php#L83, or 1.7.3 was PHP5.2 compliant? 🤔

@Matt75

This comment has been minimized.

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Mar 15, 2019

Thanks @Matt75, I close this PR, sorry @MathiasReker :/

@rblaurin

This comment has been minimized.

Copy link

rblaurin commented Mar 15, 2019

@PierreRambaud Why? PrestaShop 1.7.3 requires PHP 5.4, and DIR was introduced in 5.3, right?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Mar 15, 2019

You're right, maybe to tired ><

@PierreRambaud PierreRambaud reopened this Mar 15, 2019
@PierreRambaud PierreRambaud merged commit 1c9698c into PrestaShop:dev Mar 15, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Mar 15, 2019

Thanks @MathiasReker and sorry for the mistake 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.