Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure typescript properly to fix the build #160

Merged
merged 1 commit into from Nov 17, 2022
Merged

Configure typescript properly to fix the build #160

merged 1 commit into from Nov 17, 2022

Conversation

NeOMakinG
Copy link

Questions Answers
Description? Build wasn't working properly, probably since some core changes on develop and 8.0.x
Type? bug fix
BC breaks? no
Deprecations? no
How to test? npm i && npm run build inside views

@NeOMakinG NeOMakinG mentioned this pull request Nov 15, 2022
Merged
@MhiriFaten MhiriFaten self-assigned this Nov 16, 2022
MhiriFaten
MhiriFaten reviewed Nov 16, 2022
View reviewed changes
Copy link

@MhiriFaten MhiriFaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @NeOMakinG ,

I still find the issue and I'm still investigating.
Also, there are some checks were not successful

image

Could you check please?
Thank you.

@MhiriFaten MhiriFaten added Waiting for author Waiting for author feedback and removed Waiting for QA labels Nov 16, 2022
@MhiriFaten MhiriFaten removed their assignment Nov 16, 2022
@NeOMakinG
Copy link
Author

Hello @NeOMakinG ,

I still find the issue and I'm still investigating. Also, there are some checks were not successful

image

Could you check please? Thank you.

It's not related to that PR at all

@NeOMakinG NeOMakinG added Waiting for QA and removed Waiting for author Waiting for author feedback labels Nov 17, 2022
@MhiriFaten MhiriFaten self-assigned this Nov 17, 2022
MhiriFaten
MhiriFaten approved these changes Nov 17, 2022
View reviewed changes
Copy link

@MhiriFaten MhiriFaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @NeOMakinG ,

The build works properly 🎉

image

It's QA ✔️

Thank you!

@MhiriFaten MhiriFaten added QA ✔️ Status: QA-Approved and removed Waiting for QA labels Nov 17, 2022
@NeOMakinG NeOMakinG added this to the 5.0.6 milestone Nov 17, 2022
@NeOMakinG NeOMakinG merged commit 0d42593 into PrestaShop:dev Nov 17, 2022
@NeOMakinG
Copy link
Author

Thanks @MhiriFaten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski approved these changes

@mflasquin mflasquin mflasquin approved these changes

@MhiriFaten MhiriFaten MhiriFaten approved these changes

Assignees

@MhiriFaten MhiriFaten

Labels
QA ✔️ Status: QA-Approved
Projects
None yet
Milestone
6.0.0
4 participants
@NeOMakinG @kpodemski @mflasquin @MhiriFaten