New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fo: fix custom link id #44

Merged
merged 1 commit into from Nov 23, 2018

Conversation

Projects
None yet
4 participants
@duGuillaume

duGuillaume commented Sep 5, 2017

Fixing id attribute when title have spaces

exemple:
$el['title'] = My title;
'id' => 'link-custom-page-'.$el['title'] become id="link-custom-page-My title-2", this is not a valid id

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Nov 19, 2018

@jolelievre could you tell us if this PR is still relevant? Thanks

@jolelievre

This comment has been minimized.

Contributor

jolelievre commented Nov 19, 2018

Yep I think it is, only the Presenter moved So the modif needs to be done on

'id' => 'link-custom-page-' . $el['title'],

This is quite an old PR.. maybe we can do it for you @duGuillaume ?

@duGuillaume

This comment has been minimized.

duGuillaume commented Nov 20, 2018

@jolelievre yes please it will be great

@jolelievre

This comment has been minimized.

Contributor

jolelievre commented Nov 20, 2018

Hi @duGuillaume I'm not sure I have rights to write on your fork
So for now I integrated your changes in this PR #57
But if you prefer I can update this PR

@Quetzacoalt91 Quetzacoalt91 force-pushed the duGuillaume:patch-1 branch from cc07eba to b1da62e Nov 20, 2018

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Nov 20, 2018

Hi there,

Rebasing on dev went flawlessly, we can keep the original contribution. :)

@jolelievre

This comment has been minimized.

Contributor

jolelievre commented Nov 20, 2018

Thanks @Quetzacoalt91 I removed the modification from the other PR
Perfect!

@marionf marionf added QA ✔️ and removed Waiting for QA labels Nov 21, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 1ad1ff1 into PrestaShop:dev Nov 23, 2018

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Nov 23, 2018

Thank you @duGuillaume

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment