New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corection wrong working as widget #45

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
5 participants
@mbareja
Copy link

mbareja commented Oct 10, 2017

When using in some template this way as widget:
{widget name="ps_linklist" hook="displayFooter"}
then module make no output, beacuse in this case in method renderWidget() parameter $hookName is null and there was no read from $configuration['hook']

Corection wrong working as widget
When using in some template this way as widget:
 {widget name="ps_linklist" hook="displayFooter"}
then module make no output, beacuse in this case in method renderWidget() parameter $hookName is null and there was no read from $configuration['hook']
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Nov 19, 2018

For the QA team, this fix is valid for old versions of PrestaShop 1.7. On the newest one, the $hookName is properly defined.

@PierreRambaud PierreRambaud changed the base branch from master to dev Nov 19, 2018

@marionf marionf added QA ✔️ and removed Waiting for QA labels Nov 20, 2018

@jolelievre

This comment has been minimized.

Copy link
Contributor

jolelievre commented Nov 20, 2018

Then maybe it should be merged in a branch to release a v2.1.6?
The 3.0.0 version is only compatible with >1.7.5.0 now

@Quetzacoalt91 Quetzacoalt91 changed the base branch from dev to v2.x Jan 30, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit d8dc4e8 into PrestaShop:v2.x Jan 30, 2019

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 30, 2019

Thank you @mbareja

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment