New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade script with query syntax error, add clear cache and in in… #53

Merged
merged 2 commits into from Nov 19, 2018

Conversation

Projects
None yet
5 participants
@jolelievre
Contributor

jolelievre commented Nov 15, 2018

Fix upgrade script with query syntax error, add clear cache and install process as well

@marionf

This comment has been minimized.

marionf commented Nov 16, 2018

Do you need QA ?
It fixes #52 and PrestaShop/PrestaShop#11400 ?

@jolelievre

This comment has been minimized.

Contributor

jolelievre commented Nov 16, 2018

It should fix #52 but I don't know how to test it without merging, publishing and define a release..

About PrestaShop/PrestaShop#11400 the problem is not a the module, it's just that the beta 1 lacks some features that changed, they are present in the 1.7.5.x branch so it's not really a bug we just need to wait the next release

@marionf

This comment has been minimized.

marionf commented Nov 19, 2018

I tested it by uploading the zip of the module with your changes, this way the module is upgraded from 3.0.0 to 3.0.1 and it's ok

@marionf marionf added the QA ✔️ label Nov 19, 2018

@PierreRambaud PierreRambaud merged commit 02a20c6 into dev Nov 19, 2018

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Nov 19, 2018

Thanks @jolelievre

@PierreRambaud PierreRambaud deleted the fix-upgrade-install branch Nov 19, 2018

@123monsite-regis

This comment has been minimized.

123monsite-regis commented Nov 23, 2018

Hi
sorry @jolelievre during a test of 1.7.5 Beta Migration
it seems that there is a : '2.1.5' to 3.0.1 migration for this module , there will remain issues when updating,

PHP Fatal error: Call to undefined method Ps_Linklist::reset() in modules/ps_linklist/upgrade/upgrade-3.0.php on line 46

Do you prefere that i open a new issue as the bug will be different as the one you correct here ?
@marionf , you seem to test from 3.0.0 to 3.0.1 who does not call : upgrade/upgrade-3.0.php , or am i wrong with updates scripts auto called ?

(note that users not testing beta are not affected as compliancy is ('min' => '1.7.5.0', )

regards

@jolelievre

This comment has been minimized.

Contributor

jolelievre commented Nov 23, 2018

thanks @123monsite-regis
you might help me actually, how did you test this upgrade? because I didn't find a way to test it without releasing the module (shame one me..)
And when you uninstall/install it the upgrade is not launched either

So could you explain to me how you tested it?

(Btw I already opened another PR because I had another problem with a non existing table #57 so I will include the fix for the bug you mentioned in it)

@123monsite-regis

This comment has been minimized.

123monsite-regis commented Nov 26, 2018

hi,

i was using autoupgrade on a whole prestashop,

but if you want just to test this module upgrade, without publishing it on addons,

  • dowload it or clone it from github locally ,
  • run php composer on it to generate auotuplod folder
  • then, zip-it ,
  • and upload it from back office (install a module), on a ps with containing this module older version, ( for example ps beta 1 of 1.7.5)
    upgrade will be launch.

( maybe addons teams has a better method ?)

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Nov 26, 2018

When the version stored in config.xml / ps_linklist.php is different from the version of the module stored in the database are different, the upgrade button will be displayed (a cache clear may be needed).

This button allow the different upgrade scripts to be ran, and the version in the database to be updated.
So, you only need to upgrade the modules files (with a zip, by copy pasting in the module folder and so on).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment