New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update when table cms_block_page does not exist #57

Merged
merged 10 commits into from Dec 13, 2018

Conversation

Projects
None yet
4 participants
@jolelievre
Copy link
Contributor

jolelievre commented Nov 20, 2018

Fixes #52

jolelievre and others added some commits Nov 14, 2018

Merge pull request #50 from PrestaShop/dev
Refactor ps_linklist module using 1.7 improvements
Merge pull request #54 from PrestaShop/dev
Fix upgrade script
Merge pull request #56 from PrestaShop/dev
 Use Tools to clear cache

@jolelievre jolelievre referenced this pull request Nov 20, 2018

Merged

Fo: fix custom link id #44

@jolelievre jolelievre force-pushed the jolelievre:fix-update branch from abd7805 to 91c696a Nov 20, 2018

@jolelievre jolelievre changed the title Fix update and custom link ids Fix update when table cms_block_page does not exist Nov 20, 2018

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Nov 23, 2018

@jolelievre Could you have a look at #53 (comment)?

@jolelievre

This comment has been minimized.

Copy link
Contributor

jolelievre commented Nov 30, 2018

DO NOT MERGE I am fixing a last bug ^^

@PierreRambaud
Copy link
Contributor

PierreRambaud left a comment

Waiting for a bug Marion does not see :trollface:

@jolelievre jolelievre removed the QA ✔️ label Nov 30, 2018

@marionf

This comment has been minimized.

Copy link

marionf commented Dec 11, 2018

@jolelievre

I have this issue when I test your PR

capture d ecran_747

@jolelievre

This comment has been minimized.

Copy link
Contributor

jolelievre commented Dec 11, 2018

hi @marionf
which version of PrestaShop and of the module did you use?
I tested with the RC1 (which includes symfony cache on module installation)
And this archive for ps_linkist (which is based on the PR branch with a composer install run)
ps_linklist.zip
Everything seems to work fine

@marionf

This comment has been minimized.

Copy link

marionf commented Dec 11, 2018

I was on 1.7.5.x branch, then I went on modules folder, made a clone of ps_linklist, switch on your PR and made a composer install
I tried with RC1 and your zip and it's ok

@jolelievre

This comment has been minimized.

Copy link
Contributor

jolelievre commented Dec 11, 2018

Ok I get it, when you clone directly the branch you need to run composer install
And clear the symfony cache so that the new routing is updated
With the archive the vendor are included, and the core takes care of clearing the cache

So we're good to merge?

@jolelievre

This comment has been minimized.

Copy link
Contributor

jolelievre commented Dec 11, 2018

Oh need to update the version!!

@jolelievre

This comment has been minimized.

Copy link
Contributor

jolelievre commented Dec 11, 2018

Ok done, @PrestaShop/prestashop-product-team a little approvement, then we can merge it.

@Quetzacoalt91 Quetzacoalt91 changed the base branch from master to dev Dec 13, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 57b9ab6 into PrestaShop:dev Dec 13, 2018

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 13, 2018

Thank you @jolelievre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment