New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading time of carriers & payment pages #23 #29

Merged
merged 5 commits into from Sep 6, 2018

Conversation

Projects
None yet
4 participants
@MrBaiame
Contributor

MrBaiame commented Aug 29, 2018

No description provided.

@MrBaiame MrBaiame requested a review from PierreRambaud Aug 29, 2018

Show resolved Hide resolved ps_mbo.php Outdated
Show resolved Hide resolved ps_mbo.php Outdated
Show outdated Hide outdated ps_mbo.php Outdated
Show outdated Hide outdated ps_mbo.php Outdated
Show resolved Hide resolved ps_mbo.php Outdated
Show resolved Hide resolved ps_mbo.php Outdated
Show resolved Hide resolved ps_mbo.php Outdated
@MrBaiame

This comment has been minimized.

Show comment
Hide comment
@MrBaiame

MrBaiame Sep 4, 2018

Contributor

@marionf i think it's ready for QA

Contributor

MrBaiame commented Sep 4, 2018

@marionf i think it's ready for QA

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Sep 5, 2018

@MrBaiame
For the loading time of Payment and Carriers pages, it seems much better 👍
When I click on recommended modules on the carriers page or another legacy page, I have the issue below:

capture d ecran_257

I would like to test if this PR brings no regressions but I can't completely because of the issue #28
So, I will retest it when it will be fixed

marionf commented Sep 5, 2018

@MrBaiame
For the loading time of Payment and Carriers pages, it seems much better 👍
When I click on recommended modules on the carriers page or another legacy page, I have the issue below:

capture d ecran_257

I would like to test if this PR brings no regressions but I can't completely because of the issue #28
So, I will retest it when it will be fixed

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 5, 2018

Contributor

@marionf @Alexisvallee I will have a check this morning for this error.

Contributor

PierreRambaud commented Sep 5, 2018

@marionf @Alexisvallee I will have a check this morning for this error.

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 5, 2018

Contributor

@marionf I can't reproduce, which version of php are you using?

Contributor

PierreRambaud commented Sep 5, 2018

@marionf I can't reproduce, which version of php are you using?

@PierreRambaud PierreRambaud changed the base branch from master to dev Sep 5, 2018

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 5, 2018

Contributor

@marionf Fixed, really thanks to you for your patience!

Contributor

PierreRambaud commented Sep 5, 2018

@marionf Fixed, really thanks to you for your patience!

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Sep 5, 2018

All good, thank you @PierreRambaud 👍
So, just wait to #28 be fixed to finish the tests of this PR

marionf commented Sep 5, 2018

All good, thank you @PierreRambaud 👍
So, just wait to #28 be fixed to finish the tests of this PR

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 5, 2018

Contributor

@marionf This one should be ok too now. =)

Contributor

PierreRambaud commented Sep 5, 2018

@marionf This one should be ok too now. =)

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 5, 2018

Contributor

@MrBaiame are you ok with what I changed? If yes, we can merge it into develop.
@Quetzacoalt91 ok too?

Contributor

PierreRambaud commented Sep 5, 2018

@MrBaiame are you ok with what I changed? If yes, we can merge it into develop.
@Quetzacoalt91 ok too?

@MrBaiame

This comment has been minimized.

Show comment
Hide comment
@MrBaiame

MrBaiame Sep 6, 2018

Contributor

If it's been tested and it's OK, then yes no problem for me

Contributor

MrBaiame commented Sep 6, 2018

If it's been tested and it's OK, then yes no problem for me

@Quetzacoalt91 Quetzacoalt91 merged commit e8bda92 into dev Sep 6, 2018

@PierreRambaud PierreRambaud deleted the ajax_loading branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment