New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter catalog page #51

Merged
merged 11 commits into from Oct 5, 2018

Conversation

Projects
None yet
3 participants
@MrBaiame
Contributor

MrBaiame commented Sep 28, 2018

No description provided.

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented on ca4b9c9 Sep 26, 2018

Please use getAdminLink instead.. If we change the route in the future your code will not working anymore :/

@marionf

This comment has been minimized.

marionf commented Sep 28, 2018

@MrBaiame

2 issues:

  • When I select a category, "Categories" is still displayed instead of the name of the category selected
  • When I select a category and enter something in the search bar, it should search and display results of modules that are only in the selected category

capture d ecran_355

It works on the core:

capture d ecran_354

@marionf

This comment has been minimized.

marionf commented Sep 28, 2018

@MrBaiame

When I select "Other" category, I have no results.
I should have 6

capture d ecran_356

@MrBaiame

This comment has been minimized.

Contributor

MrBaiame commented Oct 5, 2018

Should be fixed now, ping @marionf

@marionf marionf added QA approved and removed Waiting for QA labels Oct 5, 2018

@marionf marionf referenced this pull request Oct 5, 2018

Closed

Filter issue on catalog page #40

@marionf marionf requested a review from PierreRambaud Oct 5, 2018

@PierreRambaud PierreRambaud merged commit 836b1dc into master Oct 5, 2018

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 5, 2018

Thanks @MrBaiame

@PierreRambaud PierreRambaud deleted the filter_catalog_page branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment