New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #54 - Configure link after install #55

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
3 participants
@MrBaiame
Contributor

MrBaiame commented Oct 8, 2018

@marionf marionf added the QA approved label Oct 8, 2018

@@ -657,10 +657,11 @@ var AdminModuleController = function() {
self.animateEndUpload(function() {
if (result.status === true) {
if (result.is_configurable === true) {
$(self.moduleImportSuccessConfigureBtnSelector).attr(
'href',
window.mboJavascriptUrls['configure'].replace(

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Oct 8, 2018

Member

you may also try

decodeURI(window.mboJavascriptUrls['configure']).replace(
    '%module_name%',
    result.module_name
)

This comment has been minimized.

@MrBaiame

MrBaiame Oct 8, 2018

Contributor

I just tried, it doesn't change the output unfortunately. I'll keep the %25 replace for now

@MrBaiame MrBaiame merged commit da8e4fb into master Oct 8, 2018

@MrBaiame MrBaiame deleted the fix_configurelink branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment