New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajax method renamed to be used in a display context as they should #67

Merged
merged 2 commits into from Nov 27, 2018

Conversation

Projects
None yet
5 participants
@jolelievre
Copy link
Contributor

jolelievre commented Nov 23, 2018

Questions Answers
Branch? master
Description? An error was displayed in the "Themes & Logo" page, the problem was that every ajax calls in AdminPsMboModuleController were rendered with ajaxProcess* methods This resulted in updating the view before the initial header was sent causing many cascade problems afterwards (any use to Router, or access to the session resulted in an error). Since these ajax methods were used to display the page, the appropriate prefix is displayAjax so that they are rendered at the right time during the workflow
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#11461
How to test?

This change is Reviewable

MrBaiame and others added some commits Nov 7, 2018

Merge pull request #65 from PrestaShop/dev
fix configure link

@marionf marionf self-assigned this Nov 26, 2018

@marionf marionf added QA approved and removed Waiting for QA labels Nov 26, 2018

@marionf marionf removed their assignment Nov 26, 2018

@Quetzacoalt91 Quetzacoalt91 changed the base branch from master to dev Nov 27, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit d0a5def into PrestaShop:dev Nov 27, 2018

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Nov 27, 2018

Thank you @jolelievre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment