Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean modal template from old todos #47

Merged
merged 1 commit into from Oct 14, 2019

Conversation

@matks
Copy link
Contributor

matks commented Oct 11, 2019

Questions Answers
Branch? develop
Description? Clean modal template from old todos
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? No need for QA

{*TODO: product image*}
=> I think we can remove it, the modal displays the product image so it's done

{*TODO: cross-selling*}
=> I have no idea what this means, and consequently I guess we can remove it as it cannot trigger any action

@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Oct 11, 2019

OK, cross-selling probably refers to https://github.com/PrestaShop/ps_crossselling : a small block saying "Customers who bought this product also bought..."

=> this should rather be a github issue

@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Oct 11, 2019

Issue #48 created, we can remove the todo 😁

@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Oct 14, 2019

Thanks for review

@matks matks merged commit c885856 into PrestaShop:dev Oct 14, 2019
@matks matks deleted the matks:clean-modal-tpl branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.