Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README, add LICENSE, add release-drafter config #49

Merged
merged 1 commit into from Oct 16, 2019

Conversation

@matks
Copy link
Contributor

matks commented Oct 16, 2019

No description provided.

@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Oct 16, 2019

Thank you for review

@matks matks merged commit b84b4a2 into PrestaShop:dev Oct 16, 2019
@matks matks deleted the matks:configure-repo branch Oct 16, 2019
Copy link

ttoine left a comment

one question:
the code of this module is 100% original? or does it use external libraries via Composer?
if 100% original, ok
if external libraries, there must be a "third-party-license.md" or "attribution-notice.md" or something like that, with the list of dependencies and their license.

@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Oct 16, 2019

one question:
the code of this module is 100% original? or does it use external libraries via Composer?
if 100% original, ok
if external libraries, there must be a "third-party-license.md" or "attribution-notice.md" or something like that, with the list of dependencies and their license.

100% original for this module
Other modules, like blockreassurance, rely on external libraries managed by Composer (php) and Webpack (javascript)

@ttoine

This comment has been minimized.

Copy link

ttoine commented Oct 16, 2019

so on those modules, there is a need to start to work on a "third-party-software.md". that would help to do it on small repositories, to be able to do it on the main prestashop repo.
note that like the license, this file must be included in the zip file, not just only visible on the source repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.