Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.3 #51

Merged
merged 36 commits into from Oct 30, 2019

Conversation

@matks
Copy link
Contributor

matks commented Oct 16, 2019

Summary of main bug fixes for this patch version:

  • multiple codestyle fixes (see #29 for example)
  • behavior bugfix #20
  • behavior bugfix #41
  • tech bugfix #42
unlocomqx and others added 30 commits Jun 4, 2017
Doctrine indent
…espace

Improve indentation and whitespace
…semicolons

Multiline whitespace before semicolons
Cast spaces
Blank lines
New with braces
…uest return an error

I've juste added a test to disable launching of showModal if the add to cart request (event) return an error.
As suggested by @colinegin the errors are now diplayed under the add to cart button :  PrestaShop/PrestaShop#11631 (comment)
Check that event.resp exists before testing event.resp.hasError.
This fix is required for deletint product in cart
Fix cart modal when a customized product is added to cart
The modal "add to cart confirmation" is not displayed on error
This seemed to cause a bug for some users who could not reach the checkout page.
This duplicate call would register the 'updateCart' event listener twice, therefore making 2 ajax post requests.
Add contributors file
Add and apply php cs fixer
Remove duplicate call to $(document).ready
matks added 6 commits Oct 11, 2019
Clean modal template from old todos
Update README, add LICENSE, add release-drafter config
Release 2.0.3
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Oct 18, 2019
@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Oct 18, 2019

Hi @matks !

I've noticed 2 bugs for this release (tested on 1.7.7 and 1.7.6) :

1/ When trying to uninstall, an error message pop (but the uninstall is done) :
uninstall 1

2/ On FO, the cart is hooked on the wrong display :
no shopping cart 1

It's in displayTop (screen with release)
new display SC 1

Instead of displayNav2 (screen with release)
old display SC 1

Thanks 😄

@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Oct 29, 2019

Hi @Robin-Fischer-PS I'm sorry I'm not sure these are real issues.

  1. For the "uninstall" bad notification, I fail to reproduce, I get the happy green notif with develop branch for the core (future 1.7.7):
    Capture d’écran 2019-10-29 à 15 35 10

  2. For the bad hook, you're right it seems to be in a bad place, however this is not related to this release 🤔 the displayTop is used in previous version 2.0.2 (see https://github.com/PrestaShop/ps_shoppingcart/blob/v2.0.2/ps_shoppingcart.php#L140). So this bug is not a regression from the previous version.

For 2) I guess we could fix the issue by using displayNav2 instead of displayTop however this means that any theme (or even another module) that relies on ps_shoppingcart module will suddenly see it, when updated, move to another look (although it is a patch version, which is supposed to only fix bugs, not modify behavior) 🤔 ...

@sarahdib

This comment has been minimized.

Copy link

sarahdib commented Oct 30, 2019

@matks

I didn't reproduce point 1/

For the point 2 :
this only happen if you reset the module or like @Robin-Fischer-PS uninstall the module clone the module and install.

This is not a regression I try with the previous version.

@sarahdib sarahdib added QA approved and removed Waiting for QA labels Oct 30, 2019
@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Oct 30, 2019

OK, I registered issue 2/ in #52 so we dont lose it. Thanks for QA !

@matks matks merged commit eea5469 into master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.