Prevent cookie overflow

[daresh]

The module should not store the whole history of viewed products, but only as much as configured.

Questions	Answers
Description?	"Viewed Products" module
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#26996
How to test?	Create a script displaying cookie contents and verify that only a limited amount of last viewed products gets stored there. For example: var_export(Context::getContext()->cookie);

[NeOMakinG]

@daresh PHPStan is failing

[daresh]

@NeOMakinG why? What is the error?

[AureRita]

QA by dev please

[tswfi]

so when might this get merged and new release made?

[AureRita]

friendly reminder @matks

[matks]

Hello ! sorry for late test, with the 8.0.0 feature freeze we've accumulated a lot of PRs to be checked. We're trying to catch up but it's a big pile 😅

[FabienPapet]

This fix looks OK for me and tested on my local environment, however there is a technical limitation due to cookie encryption.

Cookies are limited to a 4096 length, and if you set the PRODUCTS_VIEWED_NBR to a high value (100 for example), the encrypted cookie length will be higher than the maximum cookie size and the problem will still exist.

I think we need to validate the configuration to a maximum allowed value like 16 24 or 32 to really fix the problem.

What do you think ?

[matks]

Thank you @FabienPapet for testing this PR

I add "waiting for author" until we have @daresh answer

[daresh]

I think that's a very good idea to limit the maximum setting for the viewed products.

[matks]

@daresh can you add changes to this PR to handle @FabienPapet suggestion?

[kpodemski]

There are more and more reports about this issue. I think we should merge it as is and improve it later.

What do you think @FabienPapet @matks ?

[FabienPapet]

Good for me !

[kpodemski]

Great @FabienPapet ! Mathieu @matks ?

[matks]

OK 😄

[matks]

Thank you @daresh

[LuigiMdg]

Has been solved?