New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage new hook name displayProductAdditionalInfo #7

Merged
merged 2 commits into from Sep 10, 2018

Conversation

Projects
None yet
4 participants
@jolelievre
Contributor

jolelievre commented Aug 9, 2018

Questions Answers
Branch? master
Description? manage new hook name displayProductAdditionalInfo introduced in 1.7.1, add missing class for flex products list, better management of product list to avoid getting too many products, and integrate minor modifications
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#9916
How to test? See forge ticket
Show outdated Hide outdated ps_viewedproduct.php Outdated
}
public function install()
{
return parent::install()
&& Configuration::updateValue('PRODUCTS_VIEWED_NBR', 8)
&& $this->registerHook('displayFooterProduct')
&& $this->registerHook('displayProductButtons')
&& $this->registerHook('displayProductButtons') //Former version of displayProductAdditionalInfo
&& $this->registerHook('displayProductAdditionalInfo')

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Aug 21, 2018

Member

This method is only called for merchant installing the module.

For the others, you need to handle the upgrade which register the hook on the new version: https://devdocs.prestashop.com/1.7/modules/creation/enabling-auto-update/

@Quetzacoalt91

Quetzacoalt91 Aug 21, 2018

Member

This method is only called for merchant installing the module.

For the others, you need to handle the upgrade which register the hook on the new version: https://devdocs.prestashop.com/1.7/modules/creation/enabling-auto-update/

This comment has been minimized.

@jolelievre

jolelievre Aug 22, 2018

Contributor

done ^^

@jolelievre

jolelievre Aug 22, 2018

Contributor

done ^^

Show outdated Hide outdated ps_viewedproduct.php Outdated
Show outdated Hide outdated ps_viewedproduct.php Outdated
@jolelievre

This comment has been minimized.

Show comment
Hide comment
@jolelievre

jolelievre Sep 6, 2018

Contributor

@Quetzacoalt91 I switched this one to QA but all your requested changes should be done ;)

Contributor

jolelievre commented Sep 6, 2018

@Quetzacoalt91 I switched this one to QA but all your requested changes should be done ;)

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Sep 6, 2018

@jolelievre

I have an exception if I try to transplant the module on the left or right column

capture d ecran_281

marionf commented Sep 6, 2018

@jolelievre

I have an exception if I try to transplant the module on the left or right column

capture d ecran_281

@jolelievre

This comment has been minimized.

Show comment
Hide comment
@jolelievre

jolelievre Sep 7, 2018

Contributor

@marionf thanks, I didn't know this feature.. This is fixed!

Contributor

jolelievre commented Sep 7, 2018

@marionf thanks, I didn't know this feature.. This is fixed!

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Sep 7, 2018

All good, QA approved 👍
thank you @jolelievre

marionf commented Sep 7, 2018

All good, QA approved 👍
thank you @jolelievre

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 7, 2018

@Quetzacoalt91 Should we target dev instead of master branch?

PierreRambaud commented Sep 7, 2018

@Quetzacoalt91 Should we target dev instead of master branch?

@Quetzacoalt91 Quetzacoalt91 changed the base branch from master to dev Sep 10, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 10, 2018

Member

Yep, PRs must target the dev branch.

Member

Quetzacoalt91 commented Sep 10, 2018

Yep, PRs must target the dev branch.

jolelievre added some commits Aug 9, 2018

manage new hook name displayProductAdditionalInfo introduced in 1.7.1…
…, add missing class for flex products list, better management of product list to avoid getting too many products

@Quetzacoalt91 Quetzacoalt91 merged commit 3760024 into PrestaShop:dev Sep 10, 2018

@eternoendless eternoendless changed the title from manage new hook name displayProductAdditionalInfo to Manage new hook name displayProductAdditionalInfo Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment