Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Referencing issue #9928 of PrestaShop/PrestaShop #7
jolelievre left a comment
Hello @borlum thank you for your PR, although a few mistakes are still present
Hi @jolelievre -- I can not agree with you more; I don't like the fix myself -- but it would take me too long to find the root of the issue.
I ammended the errors you pointed out. It truly was a hotfix :-)
Thank you @borlum I also wanted to fix the core problem, actually the TaxManager is used in various places in the code, from the
I started to fetch the correct address in various places, but sometimes you simply don't know the customer so you don't have the information to fetch the correct
Your hot fix has the advantage only modify this module so at least we won't introduce any unexpected behavior for shop which don't use this module.
Our QA team is going to test your fix before we can merge it and upgrade the module.