Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "FollowSymLinks" #11

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@antondollmaier
Copy link

commented Jan 28, 2018

"+FollowSymLinks" can cause security issues, because with such a symlink into a foreign users' home directory, the webserver would be able to read files the user must not have access to. Instead, hosting providers require "SymlinksIfOwnerMatch":

https://www.drupal.org/node/2625224

Removing the line from watermark.php is probably preferred here: Prestashop itself should handle the proper mod_rewrite configuration syntax, so a single module can assume that everything is already working.

"+FollowSymLinks" can cause security issues, because with such a symlink into a foreign users' home directory, the webserver would be able to read files the user must not have access to. Instead, hosting providers require "SymlinksIfOwnerMatch":

https://www.drupal.org/node/2625224

Removing the line from watermark.php is probably preferred here: Prestashop itself should handle the proper mod_rewrite configuration syntax, so a single module can assume that everything is already working.
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Aug 28, 2019
@sarahdib sarahdib self-assigned this Aug 28, 2019
@sarahdib

This comment has been minimized.

Copy link

commented Aug 28, 2019

Hello,

@antondollmaier Thank you for your contribution 👍

@PierreRambaud PierreRambaud changed the base branch from master to dev Aug 28, 2019
@PierreRambaud PierreRambaud merged commit 7973a8a into PrestaShop:dev Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.