New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the module working on migrated payment page #39

Merged
merged 1 commit into from Sep 26, 2018

Conversation

Projects
None yet
4 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 26, 2018

Handle the DOM of the migrated payment page. Keeps the compatibility with previous versions of PrestaShop.

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 26, 2018

@@ -177,7 +177,7 @@ public function getConfiguration(Router $router)
'savepoint',
],
'page' => $contextLink->getAdminLink('AdminPayment'),
'selector' => '.modules_list_container_tab:first tr:first-child .text-muted',
'selector' => '.modules_list_container_tab:first tr:first-child .text-muted, .card:eq(0) .text-muted:eq(0)',

This comment has been minimized.

@jolelievre

jolelievre Sep 26, 2018

is the former selector still useful then?

@jolelievre

jolelievre Sep 26, 2018

is the former selector still useful then?

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Sep 26, 2018

Member

Yes, the existing selector is kept for older versions of PrestaShop 1.7. By doing this, we don't have to maintain one more version of the same module.

@Quetzacoalt91

Quetzacoalt91 Sep 26, 2018

Member

Yes, the existing selector is kept for older versions of PrestaShop 1.7. By doing this, we don't have to maintain one more version of the same module.

This comment has been minimized.

@jolelievre

jolelievre Sep 26, 2018

alright, smart!

@jolelievre

jolelievre Sep 26, 2018

alright, smart!

Show resolved Hide resolved OnBoarding/Configuration.php
@jolelievre

nice job @Quetzacoalt91 !

@marionf marionf added QA approved and removed Waiting for QA labels Sep 26, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit dad44bf into PrestaShop:dev Sep 26, 2018

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:handle-migrated-payment-page branch Sep 26, 2018

@jolelievre

This comment has been minimized.

Show comment
Hide comment
@jolelievre

jolelievre Sep 26, 2018

@Quetzacoalt91 same question for this one shouldn't it be merged in 1.7.5.x branch?

jolelievre commented Sep 26, 2018

@Quetzacoalt91 same question for this one shouldn't it be merged in 1.7.5.x branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment