New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close immediately modal on button click #40

Merged
merged 2 commits into from Sep 26, 2018

Conversation

Projects
None yet
4 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 26, 2018

Currently, the module waits for the server response to close the welcome modal. Depending on the server performance and the running ajax requests, the user may wait for a few seconds before seeing the modal actually closed.

This PR makes the module closing the modal immediately.

@jolelievre

nice job @Quetzacoalt91 ! this will save our sanity 😄

@marionf marionf added the QA approved label Sep 26, 2018

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Sep 26, 2018

Thanks @Quetzacoalt91 that thing was making me crazy everyday

marionf commented Sep 26, 2018

Thanks @Quetzacoalt91 that thing was making me crazy everyday

@Quetzacoalt91 Quetzacoalt91 merged commit 4493661 into PrestaShop:dev Sep 26, 2018

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:close-immediately-modal branch Sep 26, 2018

@jolelievre

This comment has been minimized.

Show comment
Hide comment
@jolelievre

jolelievre Sep 26, 2018

@Quetzacoalt91 sorry I just noticed shouldn't it be merged in 1.7.5.x branch?

jolelievre commented Sep 26, 2018

@Quetzacoalt91 sorry I just noticed shouldn't it be merged in 1.7.5.x branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment