Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error on publishAll with publishAlsoLocally #18

Merged
merged 1 commit into from Jun 29, 2020
Merged

fix error on publishAll with publishAlsoLocally #18

merged 1 commit into from Jun 29, 2020

Conversation

prxmat
Copy link
Contributor

@prxmat prxmat commented Jun 25, 2020

Set the publishAll method with publishAlsoLocally set to true to avoid the error: UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'closed' of undefined

@prxmat prxmat added the bug Something isn't working label Jun 25, 2020
@prxmat prxmat requested a review from Vinceveve June 25, 2020 17:13
@prxmat prxmat self-assigned this Jun 25, 2020
Vinceveve
Vinceveve approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@Vinceveve Vinceveve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci :)

@Vinceveve Vinceveve merged commit 429e4a7 into master Jun 29, 2020
@Vinceveve Vinceveve deleted the fix/publishAll branch June 29, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vinceveve Vinceveve Vinceveve approved these changes

Assignees

@prxmat prxmat

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prxmat @Vinceveve