Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-120741 Reindexing new article versions in a publication effects production #1233

Closed
wants to merge 3 commits into from

Conversation

Preston-Crary
Copy link
Owner

CC @arboliveira this doesn't fully cover the undo case but the current design expects the search index to be fully backed by the database. We don't have a system in place where the search index for production can fully diverge within a publication. At some point I'll try to come up with a system that uses search index independently from the DB for change tracking which could resolve that case. Do you see a better way?

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@Preston-Crary
Copy link
Owner Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5f15ff4b951cd6a8e9ba6ee14391ef2da378eb2d

Sender Branch:

Branch Name: LPS-120741
Branch GIT ID: 4718fac9822ff00964a0545cc5c129a8109d13b3

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 20 out of 20 jobs passed

✔️ ci:test:relevant - 54 out of 55 jobs passed in 1 hour 53 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5f15ff4b951cd6a8e9ba6ee14391ef2da378eb2d

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 5611a2ea5f71bbb21816b4787c410900ce110aed

ci:test:stable - 20 out of 20 jobs PASSED
20 Successful Jobs:
ci:test:relevant - 53 out of 55 jobs PASSED
53 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 5f15ff4:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8
    Job Results:

    182 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=1,label_exp=!master #411227
      1. ProjectTemplatesServiceBuilderTest.testCompareServiceBuilderPluginVersions
        org.junit.ComparisonFailure: com.liferay.portal.tools.service.builder versions do not match expected:<1.0.36[6]> but was:<1.0.36[5]>
        	at org.junit.Assert.assertEquals(Assert.java:115)
        	at com.liferay.project.templates.service.builder.ProjectTemplatesServiceBuilderTest.testCompareServiceBuilderPluginVersions(ProjectTemplatesServiceBuilderTest.java:256)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
        	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
        	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
        	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
        	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
        	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
        	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
        	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
        	at ...

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#94913

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants