Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-66480 #134

Closed
wants to merge 56 commits into from
Closed

LPS-66480 #134

wants to merge 56 commits into from

Conversation

@mbowerman
Copy link

mbowerman commented Jun 22, 2016

No description provided.

mtambara and others added 30 commits Jun 21, 2016
…rtalImpl.getPortletFriendlyURLMapperLayoutQueryStringComposite is fixed
vicnate5 and others added 24 commits Jun 17, 2016
…rect value before reindexing as it is used to retrieve locales"

This reverts commit 1ffd615.
if (userSession != null) {
if (sortedAttrNames != null) {
try {

This comment has been minimized.

Copy link
@Preston-Crary

Preston-Crary Jun 22, 2016

Owner

Please remove this try catch block like we talked about.

@@ -520,6 +605,9 @@ private void _signOut(

private static final LiveUsers _instance = new LiveUsers();

private static final MethodKey _getNodeUserTrackerKey = new MethodKey(

This comment has been minimized.

Copy link
@Preston-Crary

Preston-Crary Jun 22, 2016

Owner

Let's make all the method keys reference private methods.

@@ -87,6 +93,10 @@ public static UserTracker getNodeUserTracker(
return _instance._getNodeUserTracker(companyId, sessionId);
}

public static List<String> getSessionAttributes(String sessionId) {

This comment has been minimized.

Copy link
@Preston-Crary

Preston-Crary Jun 22, 2016

Owner

This should be the only public method after your changes.

@Preston-Crary

This comment has been minimized.

Copy link
Owner

Preston-Crary commented Jun 22, 2016

Please update the pull with the changes from my comments above, thanks. No need to resend, just force push the changes.

@liferay-continuous-integration

This comment has been minimized.

Copy link
Collaborator

liferay-continuous-integration commented Jun 22, 2016

Some tests FAILED!

Build Time: 49 minutes 29 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 3ea2269fd1b1a3136e8e898e3946eee6fed80cd4

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    70 Jobs Passed.
    15 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk8/12
    Job Results:

    1 Test Passed.
    1 Test Failed.

    1. PoshiRunner.test[PGAnnouncements#AddAnnouncementsEntry] - PGAnnouncements#AddAnnouncementsEntry - Poshi Summary - Console Output
  3. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk8/38
    Job Results:

    1 Test Passed.
    1 Test Failed.

    1. PoshiRunner.test[PGAnnouncements#EditAnnouncementsEntry] - PGAnnouncements#EditAnnouncementsEntry - Poshi Summary - Console Output
  4. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk8/40
    Job Results:

    1 Test Passed.
    1 Test Failed.

    1. PoshiRunner.test[PGAnnouncements#DeleteAnnouncementsEntry] - PGAnnouncements#DeleteAnnouncementsEntry - Poshi Summary - Console Output
  5. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk8/41
    Job Results:

    1 Test Passed.
    1 Test Failed.

    1. PoshiRunner.test[PGAnnouncements#ViewPreviousAnnouncementEntries] - PGAnnouncements#ViewPreviousAnnouncementEntries - Poshi Summary - Console Output
  6. ...
For upstream results, click here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.