Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSX: Bug highlighting inline object literal props #1235

Closed
jlmakes opened this issue Nov 29, 2017 · 1 comment
Closed

JSX: Bug highlighting inline object literal props #1235

jlmakes opened this issue Nov 29, 2017 · 1 comment

Comments

@jlmakes
Copy link

jlmakes commented Nov 29, 2017

Reproducing The Issue

Use an object literal for a prop value inline, such as options={{ track: true }} below:

const Component = () =>
    <Child options={{ track: true }}>
        <div>foo</div>
        <div>bar</div>
        <div>jam</div>
    </Child>

. . .

Test Drive Results

screen shot 2017-11-29 at 5 50 54 am

The highlighting for the line <Child options={{ track: true }}> is a bit off.

. . .

Just by pulling the object literal out into a variable, we can see how the highlighting kicks back in:

screen shot 2017-11-29 at 5 51 51 am

. . .

Related: #1236

@Golmote
Copy link
Contributor

Golmote commented Nov 29, 2017

Thanks for reporting. It should be fixed now. Also take a look at #1236 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants