Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added asmatmel to components. #2078

Merged
merged 18 commits into from Oct 5, 2021
Merged

Conversation

cerkit
Copy link
Contributor

@cerkit cerkit commented Sep 29, 2019

Created a new language definition for Atmel assembler.

Addresses #2077

Created a new language definition for Atmel assembler.
@cerkit cerkit changed the title Added asmatemel to components. Added asmatmel to components. Sep 29, 2019
cerkit added 3 commits Sep 29, 2019
Added tests for asmatmel language. Renamed plural constants to constant.
Fixed failing tests and added some new conditions. Fixed missing A register in language definition.
Copy link
Member

@RunDevelopment RunDevelopment left a comment

@cerkit Thank you for making this language definition!

I want to fully review your work but I can't find a spec or syntax reference to Atmel assembler. I found this one but it doesn't look like the language you describe. Unfortunately, the spec you linked didn't include enough of the language's syntax.

So could please supply some kind of introduction, syntax reference or tutorial to Atmel assembler? Some example project in Atmel asm would also be great for testing.

components.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
tests/languages/asmatmel/comment_feature.test Outdated Show resolved Hide resolved
components/prism-asmatmel.js Outdated Show resolved Hide resolved
components/prism-asmatmel.js Outdated Show resolved Hide resolved
examples/prism-asmatmel.html Outdated Show resolved Hide resolved
cerkit added 2 commits Sep 29, 2019
Reverted accidental dependency changes. Added operators and punctuation.
Changed spaces to tabs in tests to comply with project formatting requirements.
@cerkit
Copy link
Contributor Author

@cerkit cerkit commented Sep 29, 2019

@cerkit Thank you for making this language definition!

I want to fully review your work but I can't find a spec or syntax reference to Atmel assembler. I found this one but it doesn't look like the language you describe. Unfortunately, the spec you linked didn't include enough of the language's syntax.

So could please supply some kind of introduction, syntax reference or tutorial to Atmel assembler? Some example project in Atmel asm would also be great for testing.

I am a web developer by trade (mostly a middle-tier C# developer), so I just started using assembler as a hobby at home in my spare time.

I based my language definition on the asm6502 language and expanded the keywords to match what I found in the linked document. I honestly don't know the language at all and have only been doing simple examples from the docs.

I've been using the web to find help with assembler, but I have yet to find a document for the language spec. I originally just created the issue for a new language definition, but after looking at how Prism works, I decided to try to solve my own problem and close the issue.

Added additional operators.
@cerkit
Copy link
Contributor Author

@cerkit cerkit commented Sep 29, 2019

@cerkit Thank you for making this language definition!

I want to fully review your work but I can't find a spec or syntax reference to Atmel assembler. I found this one but it doesn't look like the language you describe. Unfortunately, the spec you linked didn't include enough of the language's syntax.

So could please supply some kind of introduction, syntax reference or tutorial to Atmel assembler? Some example project in Atmel asm would also be great for testing.

The one you linked to is the correct language. The link that I supplied was the list of instructions for the Atmel AVR that I'm using.

Cleaned up the operator list and added a new test for operators.
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Sep 29, 2019

Ok, then I know which language it is.

I'll re-review your PR soon.

cerkit added 5 commits Sep 29, 2019
Added PA01-PZ31, PORTA-PORTZ as well as DDDA01-DDDZ31 support with tests.
Fixed an error where a single digit constant pin value was not being evaluated (ex: PD7). Added test condition.
Added example program to light up LEDs on an Arduino UNO.
Added DDA1-DDZ9 (single digit Data Direction).
Fixed a typo with the SBIW command.
@RunDevelopment RunDevelopment self-requested a review Nov 29, 2019
@github-actions
Copy link

@github-actions github-actions bot commented Oct 5, 2021

JS File Size Changes (gzipped)

A total of 2 files have changed, with a combined diff of +983 B (+39.4%).

file master pull size diff % diff
components/prism-asmatmel.min.js 0 Bytes 973 B +973 B +100.0%
plugins/show-language/prism-show-language.min.js 2.49 KB 2.5 KB +10 B +0.4%

Generated by 🚫 dangerJS against 7136f48

@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Oct 5, 2021

Sorry for the long delay!

I quickly rebased and updated the PR, so we can merge this!

@RunDevelopment RunDevelopment merged commit b5a70e4 into PrismJS:master Oct 5, 2021
11 checks passed
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Oct 5, 2021

Thank you for contributing @cerkit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants