Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash: Add PHP dependency manager composer as a command #2298

Merged
merged 2 commits into from Apr 9, 2020
Merged

Bash: Add PHP dependency manager composer as a command #2298

merged 2 commits into from Apr 9, 2020

Conversation

@Ayesh
Copy link
Contributor

@Ayesh Ayesh commented Apr 9, 2020

Hi there,
composer is PHP's dependency manager, and I would like to propose that we add it as a command to bash language support. I see that npm is already in the list, which has equal grounds as composer.

Thank you.

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Please also add "composer" to the function test.

@RunDevelopment RunDevelopment merged commit 044dd27 into PrismJS:master Apr 9, 2020
1 check was pending
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Apr 9, 2020

Thank you for contributing @Ayesh!

@Ayesh
Copy link
Contributor Author

@Ayesh Ayesh commented Apr 9, 2020

Thank you @RunDevelopment. I'm sorry I forgot to update the tests.

@Ayesh
Copy link
Contributor Author

@Ayesh Ayesh commented Apr 9, 2020

Awesome, this is merged, thank you 🙏.

quentinvernot added a commit to TankerHQ/prismjs that referenced this issue Sep 11, 2020
This adds PHP's dependency manager `composer` to the list of commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants