Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditorConfig support #2471

Merged
merged 4 commits into from Jul 10, 2020
Merged

EditorConfig support #2471

merged 4 commits into from Jul 10, 2020

Conversation

@osipxd
Copy link
Contributor

@osipxd osipxd commented Jul 10, 2020

Tried to add EditorConfig support. Please check if I've done it right.
image

Closes #2462

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Thank you for making this language definition @osipxd!

I have a few minor suggestions but overall, it looks really good. Great work!

components/prism-editorconfig.js Outdated Show resolved Hide resolved
components/prism-editorconfig.js Show resolved Hide resolved
components/prism-editorconfig.js Outdated Show resolved Hide resolved
components/prism-editorconfig.js Outdated Show resolved Hide resolved
components/prism-editorconfig.js Outdated Show resolved Hide resolved
@osipxd osipxd requested a review from RunDevelopment Jul 10, 2020
@RunDevelopment RunDevelopment merged commit ed8fff9 into PrismJS:master Jul 10, 2020
1 check passed
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Jul 10, 2020

Thank you for contributing @osipxd!

@osipxd osipxd deleted the feature/editorconfig branch Jul 13, 2020
quentinvernot added a commit to TankerHQ/prismjs that referenced this issue Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants