Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed multiple cases of vulnerable REs #2584

Merged
merged 10 commits into from Oct 25, 2020

Conversation

@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Oct 11, 2020

This fixes #2583.

@RunDevelopment RunDevelopment mentioned this pull request Oct 12, 2020
@mAAdhaTTah
Copy link
Member

@mAAdhaTTah mAAdhaTTah commented Oct 18, 2020

Looks like a conflict to iron out. I'm not a regex expert, but all of the tests pass, so this looks good to me!

@RunDevelopment
Copy link
Member Author

@RunDevelopment RunDevelopment commented Oct 18, 2020

I'm still analyzing the results I got from @yetingli, so a few more regexes might have to be changed. I'll merge this once I'm done.

but all of the tests pass

Yeah. Most of the changes don't change the language the regex matches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants