Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSX: Temporary workaround for the collisions of JSX tags and TS generics #2596

Merged

Conversation

@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Oct 17, 2020

This implements the workaround proposed by @karlhorky.

(I also had to change the JSX tag pattern to get rid of the backreferences.)

This also fixes TSX's global namespace pollution.

@RunDevelopment RunDevelopment merged commit 25bdb49 into PrismJS:master Nov 4, 2020
1 check passed
@RunDevelopment RunDevelopment deleted the tsx-tag-generic-collisions branch Nov 4, 2020
@karlhorky
Copy link
Contributor

@karlhorky karlhorky commented Nov 4, 2020

Nice, thanks! Will the version with this be 1.22.1?

@RunDevelopment
Copy link
Member Author

@RunDevelopment RunDevelopment commented Nov 4, 2020

This will be part of 1.23.0 but before that, we will merge a few more PRs.

@karlhorky
Copy link
Contributor

@karlhorky karlhorky commented Nov 4, 2020

Sounds good, cheers :)

@badsyntax
Copy link

@badsyntax badsyntax commented Jan 7, 2021

Just want to say this change has fixed things for me. See sergioramos/remark-prism#85

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants