Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache: Update directive-flag to match '=' #2612

Merged
merged 2 commits into from Oct 26, 2020
Merged

Apache: Update directive-flag to match '=' #2612

merged 2 commits into from Oct 26, 2020

Conversation

@danielmorell
Copy link
Contributor

@danielmorell danielmorell commented Oct 26, 2020

This PR fixes an bug where directive flags are not matched consistently.

Apache configuration flags mostly follow this format...

[NC]

L,R,NC]

However, they sometimes use the following format...

[L,R=301,NC]

This simply adjusts the regex to include =.

@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Oct 26, 2020

Thank you for the PR @danielmorell!

Please add your example to this test file. You can find more information about tests here.

@danielmorell
Copy link
Contributor Author

@danielmorell danielmorell commented Oct 26, 2020

@RunDevelopment Done.

@RunDevelopment RunDevelopment merged commit 00bf00e into PrismJS:master Oct 26, 2020
6 checks passed
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Oct 26, 2020

Thank you for contributing @danielmorell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants