Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataWeave: Adding support for DataWeave language #2659

Merged
merged 14 commits into from Nov 27, 2020

Conversation

@machaval
Copy link
Contributor

@machaval machaval commented Nov 26, 2020

This pull request adds support for dataweave language.

%dw 2.0
var a = "123"
---
a

As seen in this snippet github already supports this language

@machaval machaval changed the title Adding support for DataWeave language DataWeave: Adding support for DataWeave language Nov 26, 2020
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Thank you for making this language definition @machaval!

There are a few things that have to be improved but overall solid work!

components/prism-dataweave.js Outdated Show resolved Hide resolved
components/prism-dataweave.js Outdated Show resolved Hide resolved
components/prism-dataweave.js Outdated Show resolved Hide resolved
components/prism-dataweave.js Outdated Show resolved Hide resolved
components/prism-dataweave.js Outdated Show resolved Hide resolved
components/prism-dataweave.js Outdated Show resolved Hide resolved
components/prism-dataweave.js Outdated Show resolved Hide resolved
components/prism-dataweave.js Outdated Show resolved Hide resolved
tests/languages/dataweave/comment_feature.test Outdated Show resolved Hide resolved
components/prism-dataweave.js Show resolved Hide resolved
@machaval
Copy link
Contributor Author

@machaval machaval commented Nov 27, 2020

Thanks for all the feedback I will do the required changes ASAP

@machaval machaval requested a review from RunDevelopment Nov 27, 2020
@machaval
Copy link
Contributor Author

@machaval machaval commented Nov 27, 2020

All requested changes have been fixed now. Let me know if there is anything else you would like to be changed. Again thanks for all the comments you are the Regex master!

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Thank you for the quick response @machaval!

I left you a few comments again. A few regexes and rules can be simplified and I also have some questions.

components/prism-dataweave.js Outdated Show resolved Hide resolved
components/prism-dataweave.js Outdated Show resolved Hide resolved
components/prism-dataweave.js Outdated Show resolved Hide resolved
components/prism-dataweave.js Outdated Show resolved Hide resolved
components/prism-dataweave.js Outdated Show resolved Hide resolved
components/prism-dataweave.js Outdated Show resolved Hide resolved
machaval and others added 5 commits Nov 27, 2020
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
@machaval machaval requested a review from RunDevelopment Nov 27, 2020
@machaval machaval requested a review from RunDevelopment Nov 27, 2020
machaval and others added 3 commits Nov 27, 2020
@RunDevelopment RunDevelopment merged commit 0803525 into PrismJS:master Nov 27, 2020
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants