Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for V langauge #2687

Merged
merged 7 commits into from Jan 8, 2021
Merged

Add support for V langauge #2687

merged 7 commits into from Jan 8, 2021

Conversation

@taggon
Copy link
Contributor

@taggon taggon commented Jan 1, 2021

This PR adds support for the V langauge.

@github-actions
Copy link

@github-actions github-actions bot commented Jan 1, 2021

JS File Size Changes (gzipped)

A total of 2 files have changed, with a combined diff of +969 B (+45.1%).

file master pull size diff % diff
components/prism-v.min.js 0 Bytes 967 B +967 B +100.0%
plugins/autoloader/prism-autoloader.min.js 2.15 KB 2.15 KB +2 B +0.1%

Generated by 🚫 dangerJS against c646846

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Thank you for making this PR @taggon!

I left you a few comments. Also, directives (e.g. #flag linux -lsdl2, #include "sqlite3.h") and nested multiline comments are not supported. Please add them.

Apart from that, very solid work. Thank you!

components/prism-v.js Outdated Show resolved Hide resolved
components/prism-v.js Outdated Show resolved Hide resolved
components/prism-v.js Outdated Show resolved Hide resolved
tests/v/string_feature.test Outdated Show resolved Hide resolved
tests/v/builtin_feature.test Outdated Show resolved Hide resolved
components/prism-v.js Outdated Show resolved Hide resolved
tests/v/keyword_feature.test Outdated Show resolved Hide resolved
components/prism-v.js Outdated Show resolved Hide resolved
components/prism-v.js Outdated Show resolved Hide resolved
components/prism-v.js Outdated Show resolved Hide resolved
@taggon
Copy link
Contributor Author

@taggon taggon commented Jan 7, 2021

@RunDevelopment Thanks. I fixed all the problems you mentioned and also add support for directives(such as #include and #flag).

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Thank you for your work!

I'm sorry but one of my suggestions contained faulty code. My comment contains more information and a fix.

components/prism-v.js Outdated Show resolved Hide resolved
@RunDevelopment RunDevelopment merged commit 7296270 into PrismJS:master Jan 8, 2021
8 checks passed
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Jan 8, 2021

Thank you for contributing @taggon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants