Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PSL, PATROL Scripting Language (#2735) #2739

Merged
merged 4 commits into from Jan 27, 2021

Conversation

@bertysentry
Copy link
Contributor

@bertysentry bertysentry commented Jan 25, 2021

This adds support for PSL language, the scripting language used to write modules on the PATROL Agent (BMC Software).

All tests pass :-)

@github-actions
Copy link

@github-actions github-actions bot commented Jan 25, 2021

JS File Size Changes (gzipped)

A total of 2 files have changed, with a combined diff of +1.65 KB (+75.9%).

file master pull size diff % diff
components/prism-psl.min.js 0 Bytes 1.64 KB +1.64 KB +100.0%
plugins/show-language/prism-show-language.min.js 2.17 KB 2.19 KB +13 B +0.6%

Generated by 🚫 dangerJS against fb1ef57

@bertysentry
Copy link
Contributor Author

@bertysentry bertysentry commented Jan 26, 2021

This resolves #2735

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Thank you for the PR @bertysentry!

tests/languages/psl/string_feature.test Outdated Show resolved Hide resolved
components/prism-psl.js Outdated Show resolved Hide resolved
components/prism-psl.js Outdated Show resolved Hide resolved
components/prism-psl.js Outdated Show resolved Hide resolved
components/prism-psl.js Outdated Show resolved Hide resolved
components/prism-psl.js Outdated Show resolved Hide resolved
components/prism-psl.js Outdated Show resolved Hide resolved
components/prism-psl.js Outdated Show resolved Hide resolved
tests/languages/psl/heredoc_feature.test Outdated Show resolved Hide resolved
components/prism-psl.js Outdated Show resolved Hide resolved
@bertysentry
Copy link
Contributor Author

@bertysentry bertysentry commented Jan 26, 2021

Thank you @RunDevelopment for the thorough and awesomely helpful review! I really appreciate it. I will take your suggestions into account and push the result later today.

* coloring of user-defined functions
* better operator handling
* improved tests
@bertysentry
Copy link
Contributor Author

@bertysentry bertysentry commented Jan 26, 2021

@RunDevelopment Thank you again for the help on this! Code has been updated according to your suggestions.
(with one slight variation on user-defined functions)

components/prism-psl.js Outdated Show resolved Hide resolved
components/prism-psl.js Outdated Show resolved Hide resolved
components.json Outdated Show resolved Hide resolved
@bertysentry
Copy link
Contributor Author

@bertysentry bertysentry commented Jan 27, 2021

@RunDevelopment All good? Again, thank you for the tremendous help! :-)

@RunDevelopment RunDevelopment merged commit 18c67b4 into PrismJS:master Jan 27, 2021
8 checks passed
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Jan 27, 2021

Thank you for contributing @bertysentry!

@bertysentry
Copy link
Contributor Author

@bertysentry bertysentry commented Jan 27, 2021

Thank you @RunDevelopment for your reactivity and your detailed and helpful review!

@bertysentry bertysentry deleted the feature/issue-2735-psl branch Jan 27, 2021
bertysentry added a commit to sentrysoftware/prism that referenced this issue Jan 27, 2021
Added support for PSL, PATROL Scripting Language (PrismJS#2739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants