New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated refa + fixed 2 cases of exponential backtracking #2774
Merged
RunDevelopment
merged 2 commits into
PrismJS:master
from
RunDevelopment:refa-v0.7.0-update
Mar 5, 2021
Merged
Updated refa + fixed 2 cases of exponential backtracking #2774
RunDevelopment
merged 2 commits into
PrismJS:master
from
RunDevelopment:refa-v0.7.0-update
Mar 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll merge this now cause it's kinda important. |
Should there still be anything that requires changes, please comment on this PR (or the merge commit) and I'll make the requested changes in a separate PR. |
This was referenced Jun 28, 2021
Closed
Closed
This was referenced Jul 14, 2021
This was referenced Jul 26, 2021
This was referenced Jul 6, 2023
Open
Closed
1 task
Closed
1 task
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
enhancement
language-definitions
needs review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I worked on refa over the last couple of days and added 2 major improvements:
/("|')(?:(?!\1)[^\\\r\n]|\\.)*\1/
will be parsed as/"(?:(?!")[^\\\r\n]|\\.)*"|'(?:(?!')[^\\\r\n]|\\.)*'/
./"(?:(?!")[^\\\r\n]|\\.)*"/
->/"(?:[^"\\\r\n]|\\.)*"/
.These two additions enable our current exponential backtracking test to analyze a few more regexes. And guess what, it found new cases of exponential backtracking. The AsciiDoc ones are true positives and have been fixed. The Perl one is a false positive but I "fixed" it anyway.