Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Nevod #2798

Merged
merged 25 commits into from Mar 18, 2021
Merged

Language Nevod #2798

merged 25 commits into from Mar 18, 2021

Conversation

@dmitry-surkov
Copy link
Contributor

@dmitry-surkov dmitry-surkov commented Mar 10, 2021

Add support for Nevod language used for pattern-based text search.

@github-actions
Copy link

@github-actions github-actions bot commented Mar 10, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +735 B (+100.0%).

file master pull size diff % diff
components/prism-nevod.min.js 0 Bytes 735 B +735 B +100.0%

Generated by 🚫 dangerJS against 66037d9

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Thank you for the PR @dmitry-surkov!

I left you a few comments but we also need to talk about punctuation and operators. Right now, you defined a lot of patterns. The problem with that is that our themes do not recognize these token names, leaving them unhighlighted. On your website, you solved this by modifying your themes but this a lot harder on our side.

Would it be possible to combine these patterns into an operator and a punctuation token like we do in other languages? If more granular highlighting is needed, I suggest doing it like this:

{
    'operator': [
        {
            pattern: /=/,
            alias: 'equals'
        },
        // rest
        /[-+*/]/
    ]
}

components/prism-nevod.js Outdated Show resolved Hide resolved
components/prism-nevod.js Outdated Show resolved Hide resolved
components/prism-nevod.js Outdated Show resolved Hide resolved
components/prism-nevod.js Outdated Show resolved Hide resolved
components/prism-nevod.js Outdated Show resolved Hide resolved
components/prism-nevod.js Outdated Show resolved Hide resolved
components/prism-nevod.js Outdated Show resolved Hide resolved
components/prism-nevod.js Outdated Show resolved Hide resolved
components/prism-nevod.js Outdated Show resolved Hide resolved
components/prism-nevod.js Outdated Show resolved Hide resolved
components/prism-nevod.js Outdated Show resolved Hide resolved
@dmitry-surkov
Copy link
Contributor Author

@dmitry-surkov dmitry-surkov commented Mar 18, 2021

@RunDevelopment, seems I have resolved all the issues. Do you see any other issues that prevent this PR from merge? Btw, I have also merged all changes from the PrismJS:master to the nezaboodka:language-nevod to keep PR up to date.

@RunDevelopment RunDevelopment merged commit f84c49c into PrismJS:master Mar 18, 2021
8 checks passed
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Mar 18, 2021

Thank you for contributing @dmitry-surkov!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants