Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add False #2802

Merged
merged 2 commits into from Mar 13, 2021
Merged

Add False #2802

merged 2 commits into from Mar 13, 2021

Conversation

@edukisto
Copy link
Contributor

@edukisto edukisto commented Mar 13, 2021

Resolves #2801.

@github-actions
Copy link

@github-actions github-actions bot commented Mar 13, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +260 B (+100.0%).

file master pull size diff % diff
components/prism-false.min.js 0 Bytes 260 B +260 B +100.0%

Generated by 🚫 dangerJS against ad2b3d0

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Thank you for the PR @edukisto!

2 minor nits and then it's gtg.

components/prism-false.js Outdated Show resolved Hide resolved
components/prism-false.js Outdated Show resolved Hide resolved

----------------------------------------------------

[
Copy link
Member

@RunDevelopment RunDevelopment Mar 13, 2021

This isn't a nit but a tip for the future:

This JSON looks like you formatted it yourself. With the command npm run test:languages -- --accept, the test suite will automatically insert the formatted actual token stream for you.

Copy link
Contributor Author

@edukisto edukisto Mar 13, 2021

Ah, I unreasonably forgot about --accept. I’ve never used the feature, because I write tests before I write regexes. I should and I will use it for “post-processing”.

Copy link
Contributor Author

@edukisto edukisto Mar 13, 2021

Thank you for reminding!

@edukisto edukisto requested a review from RunDevelopment Mar 13, 2021
@RunDevelopment RunDevelopment merged commit 99a21dc into PrismJS:master Mar 13, 2021
8 checks passed
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Mar 13, 2021

Thank you for contributing!

@edukisto
Copy link
Contributor Author

@edukisto edukisto commented Mar 13, 2021

Thank you, @RunDevelopment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants