Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Match Braces and Custom Class compatible #2947

Merged
merged 3 commits into from Jun 27, 2021

Conversation

@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Jun 13, 2021

This makes the two plugins compatible with each other.

CC will now expose an apply method which applies all transformations to one class name. MB will detect whether CC is loaded and use its transformation function if loaded.

Since MB will dynamically detect CC, the dependency doesn't have to be declared in components.json. The two plugins can be loaded in any order.


This resolves #2933.

@github-actions
Copy link

@github-actions github-actions bot commented Jun 13, 2021

JS File Size Changes (gzipped)

A total of 2 files have changed, with a combined diff of +68 B (+6.0%).

file master pull size diff % diff
plugins/custom-class/prism-custom-class.min.js 276 B 287 B +11 B +4.0%
plugins/match-braces/prism-match-braces.min.js 848 B 905 B +57 B +6.7%

Generated by 🚫 dangerJS against 435ecfe

@RunDevelopment RunDevelopment added this to the v1.24.0 milestone Jun 22, 2021
@RunDevelopment RunDevelopment merged commit 4b55bd6 into PrismJS:master Jun 27, 2021
11 checks passed
@RunDevelopment RunDevelopment deleted the issue2933 branch Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants