Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass: Fixed issues with CSS Extras #2994

Merged
merged 2 commits into from Jul 15, 2021
Merged

Conversation

@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Jul 11, 2021

This fixes #2992.

Sass did not expect CSS to be modified by CSS Extras. Sass 1) did not have an optional dependency for css-extras and it did not declare its tokens as greedy: true. Both of these issues have been fixed. I also improved the boundary checks of some CSS Extras tokens to make sure they can't be part of other identifiers.

@github-actions
Copy link

@github-actions github-actions bot commented Jul 11, 2021

JS File Size Changes (gzipped)

A total of 2 files have changed, with a combined diff of +18 B (+0.9%).

file master pull size diff % diff
components/prism-css-extras.min.js 1.45 KB 1.46 KB +12 B +0.8%
components/prism-sass.min.js 451 B 457 B +6 B +1.3%

Generated by 🚫 dangerJS against b961059

Loading

JaKXz
JaKXz approved these changes Jul 15, 2021
Copy link
Collaborator

@JaKXz JaKXz left a comment

LGTM :)

Loading

@RunDevelopment RunDevelopment merged commit 14fdfe3 into PrismJS:master Jul 15, 2021
11 checks passed
Loading
@RunDevelopment RunDevelopment deleted the issue2992 branch Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants