Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Bicep support #3027

Merged
merged 9 commits into from Aug 5, 2021
Merged

feat: add Bicep support #3027

merged 9 commits into from Aug 5, 2021

Conversation

@johnnyreilly
Copy link
Contributor

@johnnyreilly johnnyreilly commented Aug 5, 2021

This PR adds basic support for the Bicep language.

#2816

Snapshots generated with npm run test:languages -- --language=bicep --update

@github-actions
Copy link

@github-actions github-actions bot commented Aug 5, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +439 B (+100.0%).

file master pull size diff % diff
components/prism-bicep.min.js 0 Bytes 439 B +439 B +100.0%

Generated by 🚫 dangerJS against 7806225

Loading

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Thank you for making this PR @johnnyreilly!

I have a few questions and suggestions. Tests are failing because languages in components.json aren't sorted alphabetically (you need to swap bicep and birb).

Loading

components.json Outdated Show resolved Hide resolved
Loading
components/prism-bicep.js Show resolved Hide resolved
Loading
components/prism-bicep.js Outdated Show resolved Hide resolved
Loading
components/prism-bicep.js Outdated Show resolved Hide resolved
Loading
components/prism-bicep.js Outdated Show resolved Hide resolved
Loading
@johnnyreilly
Copy link
Contributor Author

@johnnyreilly johnnyreilly commented Aug 5, 2021

Tests should now be fixed I hope

Loading

johnnyreilly and others added 4 commits Aug 5, 2021
you're totally right

Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
components/prism-bicep.js Outdated Show resolved Hide resolved
Loading
johnnyreilly and others added 2 commits Aug 5, 2021
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
@RunDevelopment RunDevelopment merged commit c1dce99 into PrismJS:master Aug 5, 2021
11 checks passed
Loading
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Aug 5, 2021

Thank you for contributing @johnnyreilly!

Loading

@johnnyreilly
Copy link
Contributor Author

@johnnyreilly johnnyreilly commented Aug 5, 2021

Thanks for the help with the regex!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants