Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for GN #3062

Merged
merged 2 commits into from Sep 1, 2021
Merged

Added support for GN #3062

merged 2 commits into from Sep 1, 2021

Conversation

@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Sep 1, 2021

This resolves #3061.

image

@github-actions
Copy link

@github-actions github-actions bot commented Sep 1, 2021

JS File Size Changes (gzipped)

A total of 3 files have changed, with a combined diff of +558 B (+12.1%).

file master pull size diff % diff
components/prism-gn.min.js 0 Bytes 544 B +544 B +100.0%
plugins/autoloader/prism-autoloader.min.js 2.23 KB 2.24 KB +6 B +0.3%
plugins/show-language/prism-show-language.min.js 2.36 KB 2.37 KB +8 B +0.3%

Generated by 🚫 dangerJS against cd3e489

Loading

Copy link

@thunder-coding thunder-coding left a comment

https://github.com/thunder-coding/gn/blob/69ec4fca1fa69ddadae13f9e6b7507efa0675263/misc/vim/syntax/gn.vim#L19-L25

There are some predefined variables too in GN which I feel should be highlighted differently than normal variables

Loading

@RunDevelopment
Copy link
Member Author

@RunDevelopment RunDevelopment commented Sep 1, 2021

Done. I updated the screenshot so you can see the changes.

Loading

@RunDevelopment RunDevelopment merged commit 4f97b82 into PrismJS:master Sep 1, 2021
11 checks passed
Loading
@RunDevelopment RunDevelopment deleted the issue3061 branch Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants